Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dangerous workflow #2649

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix dangerous workflow #2649

merged 1 commit into from
Jun 25, 2024

Conversation

mauromorales
Copy link
Member

relates to #2647

@mauromorales
Fix dangerous workflow
a5013ef 
relates to #2647

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@mauromorales mauromorales self-assigned this Jun 25, 2024
Itxaka
Itxaka approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont get how this is considered dangerous? but whatever, looks good?

@mauromorales
Copy link
Member Author

@Itxaka yeah i was also confused about it, this doc explains it https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#example-of-a-script-injection-attack

@mauromorales mauromorales merged commit d3e446d into master Jun 25, 2024
23 of 31 checks passed
@mauromorales mauromorales deleted the fix-dangerous-workflow branch June 25, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Itxaka Itxaka Itxaka approved these changes

Assignees

@mauromorales mauromorales

Labels
None yet
Projects
🧙Issue tracking board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauromorales @Itxaka