Test selecting disk by uuid+label

[Itxaka]

What this PR does / why we need it:
Adds tests for the new functionality at kairos-io/kairos-agent#552

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1879

Will get green once the PR is merged, new version released and new framework created and added as part of this PR

[Itxaka]

It passed when building with the new branch that brings this change, now that its removed, the test should fail

[Itxaka]

now its pointing to master framework, so it should pass

EDIT: Now it has the final fix! should pass?

[jimmykarily]

I don't see any check that the correct disk was actually used. We only check that the command didn't fail and that installation occurred. I guess, since we only have one disk, it was indeed selected but would be better if we had 2 disks and we made sure the correct one was selected, to avoid for example the flag being completely ignored and the default disk (bigger one?) gets selected instead.

But it can be tricky:

kairos/tests/custom_partitioning_test.go

Lines 68 to 76 in 15f342f

	It("installs on the pre-configured disks", func() {
	Expect(installError).ToNot(HaveOccurred(), installationOutput)
	By("Rebooting into live CD again")
	// In qemu it's tricky to boot the second disk. In multiple disk scenarios,
	// setting "-boot=cd" will make qemu try to boot from the first disk and
	// then from the cdrom.
	// We want to make sure that kairos-agent selected the second disk so we
	// simply let it boot from the cdrom again. Hopefully if the installation
	// failed, we would see the error from the manual-install command.

I don't have a strong opinion, I'll let you decide.

[Itxaka]

Yes indeed, that's a good point. I am letting it work as is because if you pass a wrong or nonexistent disk, the install fails but I'll have a look at peg to see if we can pass multiple disks to the VM, that would make it more robust

[jimmykarily]

spectrocloud/peg@c12a736

[jimmykarily]

I introduced it for this exact reason. It's the boot order that is hard to do in qemu I think (see the link above).

[Itxaka]

but boot order should not matter no? It will try first all the disks and then livecd? Or it just tries the first disk only?

[jimmykarily]

I don't recall to be honest. Maybe back then I was no aware of how to setup boot order using bootindex in qemu. We need to look at it again.

[Itxaka]

You are rigth, it doesnt try to boot from the second one somehow 😭

[Itxaka]

I could not make it work, maybe we should introduce a config in peg to choose the boot device or something, would be difficult to have it working for all, but at least we could make it work for qemu

[jimmykarily]

Maybe we can add a default bootindex to all disks in qemu in peg, as in: first check disks (/dev/vda, /dev/vdb, etc) then cdrom.
This should allow us to try to target the second disk and see if it worked (since vda will be skipped as not being bootable).

[Itxaka]

Now passing :D

[jimmykarily]

/dev/vda would be the "first" disk no?

[Itxaka]

fixed!

[Itxaka]

rebase and merge once #2891 gets in with the new framework already