🐛 Do not bindly install all tpm2 tools #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were going a bit wide and installing everything under tpm2-* This brougth a userspace daemon for tpm2 which was failing to start in non-tpm enabled nodes, thus failing the systemd status and blocking boot We added a workaround to time out the service but we should directly not have that daemon in there. All our tpm2 stuff uses the in kernel tpm calls as it needs to be really early so the daemon is useless in our workflows. Signed-off-by: Itxaka <itxaka@kairos.io>
mauromorales
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were going a bit wide and installing everything under tpm2-* This brougth a userspace daemon for tpm2 which was failing to start in non-tpm enabled nodes, thus failing the systemd status and blocking boot
We added a workaround to time out the service but we should directly not have that daemon in there. All our tpm2 stuff uses the in kernel tpm calls as it needs to be really early so the daemon is useless in our workflows.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #