🐛 Move kairos vars to their own file #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise when creating derivatives, the upgrades can overwrite the existing kairos release info adn break the whole thing. This patch adds the variables into a new /]etc/kairos-release file, as well as keeping them in the usual /etc/os-release file for backwards compatibility Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
mauromorales
reviewed
Oct 1, 2024
mauromorales
reviewed
Oct 1, 2024
Signed-off-by: Itxaka <itxaka@kairos.io>
|
This needs an updated agent bundled with the changes in order to work |
jimmykarily
approved these changes
Oct 2, 2024
|
New framework image should be built to test this with changes to:
|
|
Welp, seems to work? Wtf. Okay, cutting new framework and os builder version |
Signed-off-by: Itxaka <itxaka@kairos.io>
|
Now ready to be reviewed finally :D |
|
Hello, When upgrading within kubernetes from e.g. 22.04-standard-amd64-generic-v3.2.2-k3sv1.30.5-k3s1 the upgrade gives below error and can not be applied making a symbolic link works as a workaround ln -s /etc/os-release /etc/kairos-release `+ HOST_DIR=/host
|
|
@Wolverine65 thanks, opened a ticket on #3010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise when creating derivatives, the upgrades can overwrite the existing kairos release info adn break the whole thing.
This patch adds the variables into a new /]etc/kairos-release file, as well as keeping them in the usual /etc/os-release file for backwards compatibility
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of: #2907