Log files no longer have hardcoded names, use a glob for the test #3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is still run manually and fails later when it tries to upgrade to: quay.io/kairos/kairos-opensuse:v1.0.0-rc2-k3sv1.21.14-k3s1 but I don't even know why it should be able to "upgrade" (actually downgrade) to such an old version successfully. Manually upgrading works. This fix is meant to make it easier to run the test locally until we can run it again on CI (#2709). Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
|
Merging directly. Only changes one test which we don't even run on CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is still run manually and fails later when it tries to upgrade to:
quay.io/kairos/kairos-opensuse:v1.0.0-rc2-k3sv1.21.14-k3s1
but I don't even know why it should be able to "upgrade" (actually downgrade) to such an old version successfully. Manually upgrading works.
This fix is meant to make it easier to run the test locally until we can run it again on CI (#2709).
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #