Push generic images on release and on master #3104
Conversation
also renames the jobs so they are easily identificable from the CI web Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
Itxaka
changed the title
|
|
||
| sudo mv build release | ||
| - name: Push to quay | ||
| --VARIANT=${{ matrix.variant }} |
There was a problem hiding this comment.
no k3s versions anymore? then variant can be fixed to "core"
There was a problem hiding this comment.
on release no, at least for generic and now, as we dont know how useful they are gonna be I rather not push so much shit for no reason. Base images are good currently, but I expect this to change to standard at some poitn if arm takes off.
| build-arm-generic: | ||
| needs: | ||
| - get-core-matrix-generic | ||
| runs-on: ARM64 |
There was a problem hiding this comment.
how about putting this whole section in a reusable? I'm assuming is the same to build for PR vs master, etc but maybe I'm missing something
There was a problem hiding this comment.
kind of yeah, but I wanted to test that it worked first before reqorking into a reusable job, or even reusing the existing one to build the docker images and create isos IF needed, as I dont think we should create isos/raw images from the arm stuff, just the base containers which then you can transform to an iso/raw image for your board
Signed-off-by: Itxaka <itxaka@kairos.io>
|
lets see how it breaks :D |
also renames the jobs so they are easily identificable from the CI web
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #