-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1721 enki convert image #96
Draft
jimmykarily
wants to merge
9
commits into
master
Choose a base branch
from
1721-enki-convert-image
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Sep 29, 2023
-
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Configuration menu - View commit details
-
Copy full SHA for e5987cf - Browse repository at this point
Copy the full SHA e5987cfView commit details -
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Configuration menu - View commit details
-
Copy full SHA for d741783 - Browse repository at this point
Copy the full SHA d741783View commit details -
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Configuration menu - View commit details
-
Copy full SHA for 427ccc3 - Browse repository at this point
Copy the full SHA 427ccc3View commit details -
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Configuration menu - View commit details
-
Copy full SHA for 7364f52 - Browse repository at this point
Copy the full SHA 7364f52View commit details -
Make it work (with hardcoded path)
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Configuration menu - View commit details
-
Copy full SHA for 3117e31 - Browse repository at this point
Copy the full SHA 3117e31View commit details -
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Configuration menu - View commit details
-
Copy full SHA for 459ca89 - Browse repository at this point
Copy the full SHA 459ca89View commit details -
[WIP] Refactor to add a test for the converter action
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Configuration menu - View commit details
-
Copy full SHA for 791b780 - Browse repository at this point
Copy the full SHA 791b780View commit details -
Don't assume /bin/sh is there in the base image
In other words, don't run `RUN` commands that might not be there. Ideally all `RUN` commands should run on the builder stage and at the final step, we just copy everything over. Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Configuration menu - View commit details
-
Copy full SHA for 2f0d06b - Browse repository at this point
Copy the full SHA 2f0d06bView commit details
Commits on Oct 2, 2023
-
Add earthly target to build the enki image
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Configuration menu - View commit details
-
Copy full SHA for 429e9be - Browse repository at this point
Copy the full SHA 429e9beView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.