Disable selinux for all flavors #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because in order to support selinux, we need to do more than just enable it in the cmdline. Fixes kairos-io/kairos#2802 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
mauromorales
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
I don't see any issues with the code but I wonder what impact this will have since we cannot really test easily on all different cases e.g. boards, auroraboot, different flavors, different features. But maybe we can merge it and at least have it on master and then we start seeing the tests
|
The tests passed on the other (hackish) PR. I will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because in order to support selinux, we need to do more than just enable it in the cmdline.
Fixes kairos-io/kairos#2802