Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set 'cluster-init: false' when explicitly disabled via ProviderOptions #83

Merged
merged 3 commits into from
Jul 8, 2024
Merged

fix: set 'cluster-init: false' when explicitly disabled via ProviderOptions #83

merged 3 commits into from
Jul 8, 2024

Conversation

TylerGillson
Copy link
Collaborator

@TylerGillson TylerGillson commented Jul 4, 2024 •
edited
Loading

  • Ensure "cluster-init": false is included in the K3s server config when disabled via ProviderOptions
  • Move the bulk of main.go into the provider package and split into smaller functions
  • Add unit tests for options parsing

@TylerGillson
fix: set 'cluster-init: false' when explicitly disabled via ProviderO…
aab7bb7 
…ptions

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
ci: run unit tests
7b988dd 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson
refactor: tidy
35290c8 
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson merged commit 6a9fad5 into main Jul 8, 2024
3 checks passed
@TylerGillson TylerGillson deleted the fix/handle-cluster-init branch July 8, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpiyush17 kpiyush17 kpiyush17 approved these changes

@santhoshdaivajna santhoshdaivajna Awaiting requested review from santhoshdaivajna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerGillson @kpiyush17