Fix tests #381
Merged
Fix tests #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #381 +/- ##
=======================================
Coverage 12.37% 12.37%
=======================================
Files 17 17
Lines 1067 1067
=======================================
Hits 132 132
Misses 908 908
Partials 27 27 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
because we probably get rate limited in CI Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
because on our self-hosted runners the default qemu networking doesn't allow us to ping (though I cannot answer why it worked on the old runners). Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
force-pushed
the
fix-tests-on-self-hosted-runners
branch
from
9970a28 to
25fd0ff
Compare
jimmykarily
changed the title
jimmykarily
commented
May 17, 2023
jimmykarily
commented
May 17, 2023
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
because soon, it won't even be available Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
because the command will get a `signal TERM` which is normal Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Itxaka
approved these changes
May 18, 2023
like we do in kairos: kairos-io/kairos@38da073 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: kairos-io/kairos#1416