Create empty k3s service file #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow on systemd 245 (245.4-4ubuntu3.22) becuase the k3s file was
created with no content, it marked it as a masked service and nothing
would work as expected.
Creating the file with empty service and execstart makes the service not
appear as masked and allows the override to work as expected
This patch also adds more logging to the log file, and writing the
service file before starting it.
```
root@qcs6490-odk:~# systemctl status k3s
Warning: The unit file, source configuration file or drop-ins of k3s.service changed on disk. Run 'systemctl daemon-reload' to reload units.
● k3s.service
Loaded: masked (Reason: Unit k3s.service is masked.)
Drop-In: /etc/systemd/system/k3s.service.d
└─override.conf
Active: inactive (dead)
```
Signed-off-by: Itxaka <itxaka@kairos.io>
|
This would need testing in the main kairos in all flavors to see if it affects something. It should not as we have the override I think, but just in case. Tests would fail pretty good if that is the case. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
==========================================
- Coverage 12.27% 12.05% -0.23%
==========================================
Files 17 17
Lines 1075 1095 +20
==========================================
Hits 132 132
- Misses 916 936 +20
Partials 27 27 ☔ View full report in Codecov by Sentry. |
mauromorales
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow on systemd 245 (245.4-4ubuntu3.22) becuase the k3s file was created with no content, it marked it as a masked service and nothing would work as expected.
Creating the file with empty service and execstart makes the service not appear as masked and allows the override to work as expected
This patch also adds more logging to the log file, and writing the service file before starting it.