Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [SKU-modularization] Get SKU Handler #518

Merged

Conversation

smritidahal653
Copy link
Contributor

Reason for Change:

  • Reading the CLOUD_PROVIDER environment variable and initializing the respective SKUHandler to access the correct list of gpu skus

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:
This PR does not change anything in the current implementation to keep things clean. The next PR will get rid of sku_config from v1alpha1 and carry out necessary refactoring and test updates.

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 60.73%. Comparing base (ed546f0) to head (e7c80ab).
Report is 8 commits behind head on main.

Files Patch % Lines
pkg/sku/cloud_sku_handler.go 0.00% 8 Missing ⚠️
pkg/utils/common.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   61.10%   60.73%   -0.38%     
==========================================
  Files          29       30       +1     
  Lines        2602     2618      +16     
==========================================
  Hits         1590     1590              
- Misses        921      937      +16     
  Partials       91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants