-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add controllerrevision for workspaceController #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangqipropel
requested review from
Fei-Guo,
helayoty and
ishaansehgal99
as code owners
July 18, 2024 09:51
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
==========================================
- Coverage 61.10% 58.88% -2.22%
==========================================
Files 29 30 +1
Lines 2602 2790 +188
==========================================
+ Hits 1590 1643 +53
- Misses 921 1051 +130
- Partials 91 96 +5 ☔ View full report in Codecov by Sentry. |
bangqipropel
force-pushed
the
bangqipropel/controllerrevision
branch
from
July 18, 2024 10:20
fc3c7f3
to
2ecafd0
Compare
bangqipropel
force-pushed
the
bangqipropel/controllerrevision
branch
from
July 18, 2024 18:28
2ecafd0
to
32e12ec
Compare
bangqipropel
force-pushed
the
bangqipropel/controllerrevision
branch
from
July 18, 2024 18:30
32e12ec
to
849bbdd
Compare
bangqipropel
force-pushed
the
bangqipropel/controllerrevision
branch
from
July 18, 2024 18:33
849bbdd
to
f76eed5
Compare
bangqipropel
force-pushed
the
bangqipropel/controllerrevision
branch
from
July 19, 2024 08:40
f76eed5
to
6914ba2
Compare
bangqipropel
force-pushed
the
bangqipropel/controllerrevision
branch
from
July 19, 2024 18:11
6914ba2
to
d92fd91
Compare
bangqipropel
force-pushed
the
bangqipropel/controllerrevision
branch
from
July 19, 2024 23:56
d92fd91
to
9609179
Compare
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
bangqipropel
force-pushed
the
bangqipropel/controllerrevision
branch
from
July 20, 2024 02:20
29d5a9a
to
c70a53a
Compare
Fei-Guo
reviewed
Jul 22, 2024
bangqipropel
force-pushed
the
bangqipropel/controllerrevision
branch
from
July 22, 2024 18:35
4e71c9d
to
d24fc36
Compare
bangqipropel
force-pushed
the
bangqipropel/controllerrevision
branch
from
July 22, 2024 20:24
2c4154a
to
53c5093
Compare
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
bangqipropel
force-pushed
the
bangqipropel/controllerrevision
branch
from
July 22, 2024 20:43
8ee4517
to
4f9f82c
Compare
Fei-Guo
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Add contropllerrevision for workspace controller to mark the revision
Add unit test for contropllerrevision
Requirements
Issue Fixed:
Notes for Reviewers: