Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add controllerrevision for workspaceController #524

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

bangqipropel
Copy link
Collaborator

@bangqipropel bangqipropel commented Jul 18, 2024

Reason for Change:
Add contropllerrevision for workspace controller to mark the revision
Add unit test for contropllerrevision

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 69.44444% with 22 lines in your changes missing coverage. Please review.

Project coverage is 58.88%. Comparing base (ed546f0) to head (5dbb438).
Report is 15 commits behind head on main.

Files Patch % Lines
pkg/controllers/workspace_controller.go 66.66% 18 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   61.10%   58.88%   -2.22%     
==========================================
  Files          29       30       +1     
  Lines        2602     2790     +188     
==========================================
+ Hits         1590     1643      +53     
- Misses        921     1051     +130     
- Partials       91       96       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Bangqi Zhu added 2 commits July 19, 2024 19:19
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
pkg/controllers/workspace_controller.go Outdated Show resolved Hide resolved
pkg/controllers/workspace_controller.go Outdated Show resolved Hide resolved
pkg/controllers/workspace_controller_test.go Outdated Show resolved Hide resolved
pkg/controllers/workspace_controller_test.go Outdated Show resolved Hide resolved
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
@bangqipropel bangqipropel merged commit 2ccc93d into main Jul 22, 2024
6 of 8 checks passed
@bangqipropel bangqipropel deleted the bangqipropel/controllerrevision branch July 22, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants