Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add watcher for job and avoid unnecessary reconcile #527

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

Fei-Guo
Copy link
Collaborator

@Fei-Guo Fei-Guo commented Jul 19, 2024

This PR addresses two problems:

  1. We should add watcher for tunning jobs. Otherwise, if a tunning job is deleted before it is done, the controller will not recreate it.
  2. Currently, the gpu-provisioner will update the machine object with heartbeat information every two minutes. This will trigger a workspace reconcile. In practice, if the machine keeps in the ready state, we don't need to reconcile the workspace. Add an additional machine event filter to avoid unnecessary reconciles.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.57%. Comparing base (ed546f0) to head (c109f58).
Report is 10 commits behind head on main.

Files Patch % Lines
pkg/controllers/workspace_controller.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
- Coverage   61.10%   60.57%   -0.54%     
==========================================
  Files          29       30       +1     
  Lines        2602     2625      +23     
==========================================
  Hits         1590     1590              
- Misses        921      944      +23     
  Partials       91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fei-Guo Fei-Guo merged commit 137154b into main Jul 19, 2024
7 of 9 checks passed
@Fei-Guo Fei-Guo deleted the fguo-dev1 branch July 19, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants