Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure Finalizer Patch #530

Merged
merged 4 commits into from
Jul 20, 2024
Merged

fix: Ensure Finalizer Patch #530

merged 4 commits into from
Jul 20, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

Reason for Change:
This is some code cleanup on ensure finalizer. Main change is moving code into seperate if statement and using a patch instead of update to add finalizer.

@ishaansehgal99 ishaansehgal99 changed the title fix: Ensure Finalizer fix: Ensure Finalizer Path Jul 20, 2024
@ishaansehgal99 ishaansehgal99 changed the title fix: Ensure Finalizer Path fix: Ensure Finalizer Patch Jul 20, 2024
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 59.10%. Comparing base (ed546f0) to head (8c23492).
Report is 13 commits behind head on main.

Files Patch % Lines
pkg/controllers/workspace_controller.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
- Coverage   61.10%   59.10%   -2.00%     
==========================================
  Files          29       30       +1     
  Lines        2602     2695      +93     
==========================================
+ Hits         1590     1593       +3     
- Misses        921     1010      +89     
- Partials       91       92       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 merged commit 4fdecc2 into main Jul 20, 2024
6 of 8 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/ensure-finalizer branch July 20, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants