-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use SKU GPU Count in DeploymentSpec #541
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishaansehgal99
had a problem deploying
to
unit-tests
July 29, 2024 21:19
— with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
July 29, 2024 21:21
— with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
July 29, 2024 21:21
— with
GitHub Actions
Failure
…into Ishaan/fix-gpu-usage
ishaansehgal99
had a problem deploying
to
unit-tests
July 29, 2024 21:34
— with
GitHub Actions
Failure
ishaansehgal99
temporarily deployed
to
unit-tests
July 29, 2024 21:55
— with
GitHub Actions
Inactive
ishaansehgal99
had a problem deploying
to
e2e-test
July 29, 2024 21:56
— with
GitHub Actions
Failure
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #541 +/- ##
==========================================
- Coverage 61.10% 57.00% -4.11%
==========================================
Files 29 30 +1
Lines 2602 2912 +310
==========================================
+ Hits 1590 1660 +70
- Misses 921 1157 +236
- Partials 91 95 +4 ☔ View full report in Codecov by Sentry. |
ishaansehgal99
had a problem deploying
to
unit-tests
July 31, 2024 17:43
— with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
July 31, 2024 17:45
— with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
July 31, 2024 17:47
— with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
July 31, 2024 20:19
— with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
July 31, 2024 20:28
— with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
July 31, 2024 21:22
— with
GitHub Actions
Error
Fei-Guo
reviewed
Jul 31, 2024
ishaansehgal99
had a problem deploying
to
unit-tests
July 31, 2024 21:49
— with
GitHub Actions
Error
ishaansehgal99
temporarily deployed
to
unit-tests
July 31, 2024 21:54
— with
GitHub Actions
Inactive
Fei-Guo
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Cases were workspace was not utilizing all available GPUs on machine by default this was causing slower inference requests and unused resources. This is the fix.