Replace custom comment hardcoded HTML with include

Also add custom_scripts.html include for custom comment provider JavaScript that loads in the footer. Close mmistakes#2549
kaitokikuchi · Jun 3, 2020 · aba3099 · aba3099
1 parent 9ce13bc
commit aba3099
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ### Enhancements
 
+- Replace `<section id="custom-comments"></section>` in `comments.html` include and add `custom_scripts.html` include for loading custom comment provider JavaScript in the footer. [#2549](https://github.com/mmistakes/minimal-mistakes/issues/2549)
 - Move page date Liquid to include. [#2544](https://github.com/mmistakes/minimal-mistakes/pull/2544)
 - Strip trailing whitespace in seo_description. [#2542](https://github.com/mmistakes/minimal-mistakes/pull/2542)
 - Improve sticky sidebar's appearance with short content. [#2514](https://github.com/mmistakes/minimal-mistakes/pull/2514)

diff --git a/_includes/comments-providers/custom_scripts.html b/_includes/comments-providers/custom_scripts.html
@@ -0,0 +1,3 @@
+<!-- start custom comments scripts -->
+
+<!-- end custom comments scripts -->
diff --git a/_includes/comments-providers/scripts.html b/_includes/comments-providers/scripts.html
@@ -13,6 +13,6 @@
   {% when "utterances" %}
     {% include /comments-providers/utterances.html %}
   {% when "custom" %}
-    {% include /comments-providers/custom.html %}
+    {% include /comments-providers/custom_scripts.html %}
 {% endcase %}
 {% endif %}
diff --git a/_includes/comments.html b/_includes/comments.html
@@ -154,6 +154,6 @@ <h4 class="page__comments-title">{{ site.data.ui-text[site.locale].comments_labe
       <h4 class="page__comments-title">{{ comments_label }}</h4>
       <section id="utterances-comments"></section>
     {% when "custom" %}
-      <section id="custom-comments"></section>
+      {% include /comments-providers/custom.html %}
   {% endcase %}
 </div>
diff --git a/docs/_docs/18-history.md b/docs/_docs/18-history.md
@@ -5,14 +5,15 @@ permalink: /docs/history/
 excerpt: "Change log of enhancements and bug fixes made to the theme."
 sidebar:
   nav: docs
-last_modified_at: 2020-06-02T22:23:56-04:00
+last_modified_at: 2020-06-02T22:31:55-04:00
 toc: false
 ---
 
 ## Unreleased
 
 ### Enhancements
 
+- Replace `<section id="custom-comments"></section>` in `comments.html` include and add `custom_scripts.html` include for loading custom comment provider JavaScript in the footer. [#2549](https://github.com/mmistakes/minimal-mistakes/issues/2549)
 - Move page date Liquid to include. [#2544](https://github.com/mmistakes/minimal-mistakes/pull/2544)
 - Strip trailing whitespace in `seo_description`. [#2542](https://github.com/mmistakes/minimal-mistakes/pull/2542)
 - Improve sticky sidebar's appearance with short content. [#2514](https://github.com/mmistakes/minimal-mistakes/pull/2514)