Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.ts to add Apache Doris incubating #80

Merged
merged 2 commits into from
Mar 19, 2020

Conversation

morningman
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following linting issues need to be fixed in order to make this PR pass the CI tests.

/home/travis/build/kaiyuanshe/osschat/src/config.ts
  61:3  error  Expected object keys to be in ascending order. 'apache/incubator-doris' should be before 'qihoo360/quicksql'  sort-keys
  64:1  error  Too many blank lines at the end of file. Max of 0 allowed                                                     no-multiple-empty-lines

@huan
Copy link
Collaborator

huan commented Mar 19, 2020

@morningman Welcome onboarding! Please make the CI turns green before we can merge your PR, Thanks!

Copy link
Collaborator

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan merged commit c4b67ae into kaiyuanshe:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants