Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wx-work bot template #84

Merged
merged 7 commits into from
Apr 1, 2020
Merged

add wx-work bot template #84

merged 7 commits into from
Apr 1, 2020

Conversation

lijiarui
Copy link
Collaborator

@lijiarui lijiarui commented Mar 26, 2020

I'm submitting a...

Related to #85

[ ] Bug Fix
[x] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

please describe the changes that you are making

for features, please describe how to use the new feature

WeChat Work provides a room bot, using a webhook, it can push notification to WeChat work room. This commit helps us to push GitHub notifications to WeChat work room.

please include a reference to an existing issue, if applicable

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link
Collaborator

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix your code so that we can merge it.

@@ -183,6 +183,11 @@ async function manageIssue (
'issue card for chatops',
)

if (owner === 'juzibot' && repository === 'Juzi-WeChat-Work-Tasks') {
const wxBotUrl = 'https://qyapi.weixin.qq.com/cgi-bin/webhook/send?key=974db6af-6b24-41aa-8da6-5ed634d24fcf'
require(wxBotUrl)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe here should be request instead of require.

package.json Outdated
@@ -28,6 +28,7 @@
},
"homepage": "https://github.com/kaiyuanshe/OSSChat#readme",
"dependencies": {
"@types/request": "^2.48.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move @types to dev dependencies.

Thanks!

@huan huan merged commit 9c02598 into master Apr 1, 2020
@huan huan deleted the wx-work branch April 1, 2020 08:09
@huan
Copy link
Collaborator

huan commented Apr 1, 2020

Terrific!

We start supporting WXWorks from today, thanks jiarui!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants