Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user group for dolphinscheduler #86

Merged
merged 4 commits into from
Mar 28, 2020
Merged

add user group for dolphinscheduler #86

merged 4 commits into from
Mar 28, 2020

Conversation

davidzollo
Copy link

add user group for dolphinscheduler

I'm submitting a...

[ ] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

please describe the changes that you are making

for features, please describe how to use the new feature

please include a reference to an existing issue, if applicable

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

@huan
Copy link
Collaborator

huan commented Mar 28, 2020

/home/travis/build/kaiyuanshe/osschat/src/config.ts
  48:27  error  Missing trailing comma       comma-dangle
  49:5   error  Trailing spaces not allowed  no-trailing-spaces

You need to fix the above two issues before the CI can be happy.

@davidzollo
Copy link
Author

already fixed , haha

Copy link
Collaborator

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan merged commit 8ba167f into kaiyuanshe:master Mar 28, 2020
@huan
Copy link
Collaborator

huan commented Mar 28, 2020

Terrific fix! merged! :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants