fix: switch to mkdirp for Node 8

kaizhu256 · May 3, 2019 · 206b83f · 206b83f
1 parent 72bf019
commit 206b83f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/bin/c8.js b/bin/c8.js
@@ -1,9 +1,9 @@
 #!/usr/bin/env node
 'use strict'
 
-const fs = require('fs')
 const foreground = require('foreground-child')
 const { outputReport } = require('../lib/commands/report')
+const mkdirp = require('mkdirp')
 const { promisify } = require('util')
 const rimraf = require('rimraf')
 const {
@@ -24,7 +24,8 @@ let argv = buildYargs().parse(instrumenterArgs)
     if (argv.clean) {
       await promisify(rimraf)(argv.tempDirectory)
     }
-    await promisify(fs.mkdir)(argv.tempDirectory, { recursive: true })
+    // allow c8 to run on Node 8 (coverage just won't work).
+    await promisify(mkdirp)(argv.tempDirectory)
 
     process.env.NODE_V8_COVERAGE = argv.tempDirectory
     foreground(hideInstrumenterArgs(argv), async (done) => {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -39,6 +39,7 @@
     "istanbul-lib-coverage": "^2.0.1",
     "istanbul-lib-report": "^2.0.1",
     "istanbul-reports": "^2.0.0",
+    "mkdirp": "^0.5.1",
     "rimraf": "^2.6.2",
     "test-exclude": "^5.0.0",
     "v8-to-istanbul": "^3.1.1",