fix: exit with code 1 when report output fails (bcoe#92)

kaizhu256 · May 4, 2019 · a27b694 · a27b694
1 parent 6b93355
commit a27b694
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/bin/c8.js b/bin/c8.js
@@ -29,7 +29,12 @@ async function run () {
 
     process.env.NODE_V8_COVERAGE = argv.tempDirectory
     foreground(hideInstrumenterArgs(argv), async (done) => {
-      await outputReport(argv)
+      try {
+        await outputReport(argv)
+      } catch (err) {
+        console.error(err.stack)
+        process.exitCode = 1
+      }
       done()
     })
   }

diff --git a/test/integration.js b/test/integration.js
@@ -53,6 +53,18 @@ describe('c8', () => {
     )
   })
 
+  it('exits with 1 when report output fails', () => {
+    const { status, stderr } = spawnSync(nodePath, [
+      c8Path,
+      '--clean=false',
+      '--reporter=unknown',
+      nodePath,
+      '--version'
+    ])
+    status.should.equal(1)
+    stderr.toString().should.match(/Cannot find module 'unknown'/u)
+  })
+
   describe('check-coverage', () => {
     before(() => {
       spawnSync(nodePath, [