feat: warn instead of throw on exception (bcoe#29)

kaizhu256 · Sep 16, 2018 · a8620d4 · a8620d4
1 parent 522720e
commit a8620d4
Show file tree

Hide file tree

Showing 3 changed files with 106 additions and 12 deletions.
diff --git a/lib/report.js b/lib/report.js
@@ -60,11 +60,15 @@ class Report {
     })
 
     Object.keys(mergedResults).forEach((url) => {
-      const result = mergedResults[url]
-      const path = resolve(this.resolve, result.url)
-      const script = v8toIstanbul(path)
-      script.applyCoverage(result.functions)
-      map.merge(script.toIstanbul())
+      try {
+        const result = mergedResults[url]
+        const path = resolve(this.resolve, result.url)
+        const script = v8toIstanbul(path)
+        script.applyCoverage(result.functions)
+        map.merge(script.toIstanbul())
+      } catch (err) {
+        console.warn(`file: ${url} error: ${err.stack}`)
+      }
     })
 
     return map
@@ -73,10 +77,14 @@ class Report {
     const files = readdirSync(this.tempDirectory)
 
     return files.map((f) => {
-      return JSON.parse(readFileSync(
-        resolve(this.tempDirectory, f),
-        'utf8'
-      ))
+      try {
+        return JSON.parse(readFileSync(
+          resolve(this.tempDirectory, f),
+          'utf8'
+        ))
+      } catch (err) {
+        console.warn(`${err.stack}`)
+      }
     })
   }
 }

diff --git a/package-lock.json b/package-lock.json
diff --git a/test/integration.js.snap b/test/integration.js.snap
@@ -8,12 +8,12 @@ second
 --------------------|----------|----------|----------|----------|-------------------|
 File                |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
 --------------------|----------|----------|----------|----------|-------------------|
-All files           |    94.12 |    70.59 |        0 |    94.12 |                   |
+All files           |     92.5 |    69.23 |        0 |     92.5 |                   |
  bin                |    83.72 |    57.14 |      100 |    83.72 |                   |
   c8.js             |    83.72 |    57.14 |      100 |    83.72 |... 22,40,41,42,43 |
- lib                |    96.41 |    65.38 |      100 |    96.41 |                   |
+ lib                |    93.71 |    62.96 |      100 |    93.71 |                   |
   parse-args.js     |    97.47 |    44.44 |      100 |    97.47 |             55,56 |
-  report.js         |    95.45 |    76.47 |      100 |    95.45 |       51,52,53,54 |
+  report.js         |    90.63 |    72.22 |      100 |    90.63 |... 70,71,85,86,87 |
  test/fixtures      |    95.16 |    83.33 |        0 |    95.16 |                   |
   async.js          |      100 |      100 |      100 |      100 |                   |
   multiple-spawn.js |      100 |      100 |      100 |      100 |                   |