Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: 콜백 가이드라인 type 추가 #223

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Feat: 콜백 가이드라인 type 추가 #223

merged 5 commits into from
Nov 12, 2024

Conversation

eunsoni
Copy link
Collaborator

@eunsoni eunsoni commented Nov 12, 2024

#️⃣ 연관된 이슈

📝 작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요.(이미지 첨부 가능)

  • 엔터티 수정
  • 더미데이터 추가
  • 엔터티테스트 수정

스크린샷 (선택)

💬 리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

⏰ 현재 버그

✏ Git Close

close #222

@eunsoni eunsoni added ✨ Feature 새로운 기능 추가 및 구현하는 경우 ✅ Test Code 테스트 관련 작업을 진행하는 경우 ♻️ Refactoring 코드 리팩토링 & 클린 코드 작업을 진행하는 경우 labels Nov 12, 2024
@eunsoni eunsoni self-assigned this Nov 12, 2024
@eunsoni eunsoni linked an issue Nov 12, 2024 that may be closed by this pull request
Feat: 가이드라인 타입 추가 #222
Closed
3 tasks
@eunsoni eunsoni requested review from 2iedo, zzoe2346 and GitJIHO and removed request for 2iedo November 12, 2024 11:56
GitJIHO
GitJIHO approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@GitJIHO GitJIHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요~~ 👍

src/main/java/com/example/sinitto/common/dummy/InitialData.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오우 엄청 많이 추가하셨네요 👍

zzoe2346
zzoe2346 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@zzoe2346 zzoe2346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!👏

2iedo
2iedo approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@2iedo 2iedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요~~

@eunsoni eunsoni merged commit 169f884 into Weekly Nov 12, 2024
1 check passed
@2iedo 2iedo deleted the Feat/issue-#222 branch November 14, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2iedo 2iedo 2iedo approved these changes

@GitJIHO GitJIHO GitJIHO approved these changes

@zzoe2346 zzoe2346 zzoe2346 approved these changes

Assignees

@eunsoni eunsoni

Labels
✨ Feature 새로운 기능 추가 및 구현하는 경우 ♻️ Refactoring 코드 리팩토링 & 클린 코드 작업을 진행하는 경우 ✅ Test Code 테스트 관련 작업을 진행하는 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: 가이드라인 타입 추가
4 participants
@eunsoni @zzoe2346 @GitJIHO @2iedo