Skip to content

Commit

Permalink
Merge pull request #147 from kakao/rm-unnecessary-report-log
Browse files Browse the repository at this point in the history
refactor(mr): remove unnecessary report log
  • Loading branch information
hungryjang authored Sep 13, 2022
2 parents d358923 + 4a35590 commit 1340bba
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions internal/metarepos/storage.go
Original file line number Diff line number Diff line change
Expand Up @@ -1102,13 +1102,15 @@ func (ms *MetadataStorage) UpdateUncommitReport(lsID types.LogStreamID, snID typ
}

if !ms.verifyUncommitReport(s) {
ms.logger.Warn("could not apply report: invalid ver",
zap.Int32("lsid", int32(lsID)),
zap.Int32("snid", int32(snID)),
zap.Uint64("ver", uint64(s.Version)),
zap.Uint64("first", uint64(ms.getFirstCommitResultsNoLock().GetVersion())),
zap.Uint64("last", uint64(ms.getLastCommitResultsNoLock().GetVersion())),
)
if !lm.Status.Sealed() {
ms.logger.Warn("could not apply report: invalid ver",
zap.Int32("lsid", int32(lsID)),
zap.Int32("snid", int32(snID)),
zap.Uint64("ver", uint64(s.Version)),
zap.Uint64("first", uint64(ms.getFirstCommitResultsNoLock().GetVersion())),
zap.Uint64("last", uint64(ms.getLastCommitResultsNoLock().GetVersion())),
)
}
return
}

Expand Down

0 comments on commit 1340bba

Please sign in to comment.