Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework benchmark tool #209

Closed
ijsong opened this issue Nov 1, 2022 · 0 comments · Fixed by #233 or #181
Closed

Rework benchmark tool #209

ijsong opened this issue Nov 1, 2022 · 0 comments · Fixed by #233 or #181
Assignees

Comments

@ijsong
Copy link
Member

ijsong commented Nov 1, 2022

There is already a benchmark-like tool in cmd/stress, but we need to rework it for the following reasons:

  • Only AppendTo RPC is supported, but various RPC results such as Append and Subscribe are often required.
  • It only reports the full metrics since the start of the benchmark; however, it cannot report the latest metrics.
  • Expanding metrics is cumbersome. For example, adding a new metric requires a lot of code to define and report the metric.

In addition to the above, the old tool has more to improve.

@ijsong ijsong self-assigned this Nov 11, 2022
ijsong added a commit to ijsong/varlog that referenced this issue Nov 21, 2022
This patch reworked the benchmark tool. This PR is the first version of it.

Resolves kakao#209
ijsong added a commit to ijsong/varlog that referenced this issue Nov 21, 2022
This patch reworked the benchmark tool. This PR is the first version of it.

Resolves kakao#209
ijsong added a commit to ijsong/varlog that referenced this issue Nov 21, 2022
This patch reworked the benchmark tool. This PR is the first version of it.

Resolves kakao#209
ijsong added a commit to ijsong/varlog that referenced this issue Nov 22, 2022
This patch reworked the benchmark tool. This PR is the first version of it.

Resolves kakao#209
ijsong added a commit to ijsong/varlog that referenced this issue Nov 22, 2022
This patch reworked the benchmark tool. This PR is the first version of it.

Resolves kakao#209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant