fix(storagenode): fix error-prone state management of SyncInit and Report #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port When a log stream replica handles SyncInit, it can be prone to mutate the replica's state too early. It should change the state after checking a valid sync range. It also updates the version, high watermark, and uncommittedLLSNBegin with zeros to denote that the replica sends an invalid report while the learning phase. The replica checks whether it is in the learning phase at the end of method `internal/storagenode/logstream.(*Executor).Report` to minimize the probability of concurrency issues mentioned in kakao#159. Refs - kakao#159 (comment)
Codecov ReportBase: 62.85% // Head: 62.99% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 62.85% 62.99% +0.14%
==========================================
Files 126 126
Lines 17061 17064 +3
==========================================
+ Hits 10723 10749 +26
+ Misses 5781 5760 -21
+ Partials 557 555 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hungryjang
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
When a log stream replica handles SyncInit, it can be prone to mutate the replica's state too early.
It should change the state after checking a valid sync range. It also updates the version, high
watermark, and uncommittedLLSNBegin with zeros to denote that the replica sends an invalid report
while the learning phase.
The replica checks whether it is in the learning phase at the end of method
internal/storagenode/logstream.(*Executor).Reportto minimize the probability of concurrencyissues mentioned in #159.
Anything else
Refs