Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metarepos): ignore invalid report #163

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Conversation

hungryjang
Copy link
Member

What this PR does

This patch allows the metadata repository to ignore invalid reports from storagenode. Since storagenode is changed
not to save the commit context, an invalid report may be given in the learning state.

Which issue(s) this PR resolves

Updates #125

Anything else

Include any links or documentation that might be helpful for reviewers.

@hungryjang hungryjang requested a review from ijsong as a code owner September 23, 2022 15:09
proto/snpb/log_stream_reporter.go Outdated Show resolved Hide resolved
internal/metarepos/raft_metadata_repository_test.go Outdated Show resolved Hide resolved
internal/metarepos/report_collector_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Base: 62.85% // Head: 63.02% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (2bcf5fc) compared to base (0a14ab5).
Patch coverage: 45.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   62.85%   63.02%   +0.17%     
==========================================
  Files         126      126              
  Lines       17061    17075      +14     
==========================================
+ Hits        10723    10762      +39     
+ Misses       5781     5765      -16     
+ Partials      557      548       -9     
Impacted Files Coverage Δ
proto/snpb/log_stream_reporter.go 0.00% <0.00%> (ø)
internal/metarepos/report_collector.go 77.85% <10.00%> (-0.43%) ⬇️
...metarepos/dummy_storagenode_client_factory_impl.go 64.62% <100.00%> (+2.12%) ⬆️
internal/metarepos/raft_metadata_repository.go 71.98% <100.00%> (+0.31%) ⬆️
internal/metarepos/storage.go 81.06% <0.00%> (+1.40%) ⬆️
internal/storagenode/replication_server.go 83.00% <0.00%> (+6.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ijsong ijsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your commit.

@hungryjang hungryjang merged commit 18b34c6 into main Sep 26, 2022
@hungryjang hungryjang deleted the ignore-invalid-report branch September 26, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants