feat(storagenode): restore the status of a log stream replica by using the latest commit context #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 63.05% // Head: 62.87% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 63.05% 62.87% -0.19%
==========================================
Files 126 126
Lines 17137 17156 +19
==========================================
- Hits 10806 10787 -19
- Misses 5773 5814 +41
+ Partials 558 555 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hungryjang
reviewed
Oct 5, 2022
…g the latest commit context This patch changes how to restore the status of a log stream replica after kakao#162. Previously, the log stream replica reads a sequence of all commit contexts to decide whether it can work well after restoring. However, since the replica will maintain only the latest commit context, we should change the previous approach to reloading a replica. The log stream replica reads the last commit context and boundary of log entries and checks if it recovers its status. The replica runs if the recovery completes. However, if there is something wrong, its reportCommitBase will be invalid. In that case, the metadata repository will ignore its report, and cloning the log entries from the other replica will occur. Updates kakao#125
ijsong
force-pushed
the
fix-reload-logstream
branch
from
d869711 to
9e042d2
Compare
hungryjang
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This patch changes how to restore the status of a log stream replica after
#162. Previously, the log stream replica reads a sequence of all commit
contexts to decide whether it can work well after restoring. However, since the
replica will maintain only the latest commit context, we should change the
previous approach to reloading a replica.
The log stream replica reads the latest commit context and boundary of log
entries and checks if it recovers its status. The replica runs if the recovery
completes. However, if there is something wrong, its reportCommitBase will be
invalid. In that case, the metadata repository will ignore its report, and
cloning the log entries from the other replica will occur.
Which issue(s) this PR resolves
Updates #125
Anything else