refactor(storage): do not write a commit context for each commit #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijsong
changed the title
ijsong
force-pushed
the
cleanup-old-commit-context-codes
branch
from
cba0658 to
5f981fc
Compare
ijsong
force-pushed
the
cleanup-old-commit-context-codes
branch
3 times, most recently
from
35317c5 to
bcea30c
Compare
hungryjang
approved these changes
Nov 22, 2022
ijsong
force-pushed
the
cleanup-old-commit-context-codes
branch
from
bcea30c to
e71a83b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Previously, the log stream wrote a commit context for each commit. However, to
fix #125, we no longer need to persist in a sequence of commit contexts. So
this patch removes lines that keep all commit context.
Which issue(s) this PR resolves
Updates #125