Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use four-space indent size for go source files #214

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Nov 3, 2022

What this PR does

I talked with @hungryjang about the indent size of our project to set it to four spaces rather than
a tab.

I talked with @hungryjang about the indent size of our project to set it to four spaces rather than
a tab.
@ijsong ijsong self-assigned this Nov 3, 2022
@ijsong ijsong marked this pull request as ready for review November 3, 2022 17:11
@ijsong ijsong requested a review from hungryjang as a code owner November 3, 2022 17:11
@codecov-commenter
Copy link

Codecov Report

Base: 63.11% // Head: 63.09% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (54b6b83) compared to base (34fed84).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   63.11%   63.09%   -0.03%     
==========================================
  Files         130      130              
  Lines       17484    17484              
==========================================
- Hits        11035    11031       -4     
- Misses       5891     5892       +1     
- Partials      558      561       +3     
Impacted Files Coverage Δ
pkg/varlog/subscribe.go 0.00% <0.00%> (ø)
internal/storagenode/replication_server.go 77.00% <0.00%> (-3.00%) ⬇️
internal/metarepos/storage.go 78.69% <0.00%> (-0.99%) ⬇️
internal/storagenode/logstream/executor.go 75.75% <0.00%> (-0.57%) ⬇️
internal/storagenode/storagenode.go 68.64% <0.00%> (+0.34%) ⬆️
internal/metarepos/report_collector.go 77.85% <0.00%> (+0.42%) ⬆️
...metarepos/dummy_storagenode_client_factory_impl.go 63.90% <0.00%> (+1.32%) ⬆️
internal/storagenode/logstream/committer.go 81.03% <0.00%> (+2.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ijsong ijsong merged commit b25b869 into kakao:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants