fix(storagenode): support partial success/failure for append

[ijsong]

What this PR does

The Append RPC function allows batch logging but may occasionally only partially succeed. The
storage node previously overlooked partial success, but this PR fixes to consider partial success.

[ijsong]

Current dependencies on/for this PR:

• main
  • PR ci(lint): fix depguard configuration #463
    • PR feat(storagenode): change append rpc from unary to stream #449
      • PR fix(storagenode): support partial success/failure for append #450 👈
        • PR feat(storagenode): add configurations for initial window size #451
          • PR feat(storagenode): add pipelined Append RPC handler #457
            • PR feat(client): add LogStreamAppender #459
              • PR test(benchmark): support log stream appender #462

This comment was auto-generated by Graphite.

[codecov-commenter]

Codecov Report

Patch coverage: 87.50% and project coverage change: +0.01 🎉

Comparison is base (2cea668) 63.24% compared to head (b93c628) 63.26%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@                         Coverage Diff                         @@
##           append_rpc_from_unary_to_stream     #450      +/-   ##
===================================================================
+ Coverage                            63.24%   63.26%   +0.01%     
===================================================================
  Files                                  132      132              
  Lines                                17933    17940       +7     
===================================================================
+ Hits                                 11342    11349       +7     
+ Misses                                6023     6022       -1     
- Partials                               568      569       +1     

Impacted Files	Coverage Δ
internal/storagenode/logstream/append.go	79.69% <87.50%> (-1.26%)	⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ijsong]

@ijsong started a stack merge that includes this pull request via Graphite.

[ijsong]

@ijsong merged this pull request with Graphite.