Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): can call Close at callback in LogStreamAppender #473

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Jun 12, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (7fa53f3) 62.58% compared to head (77b8de8) 62.65%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           lsa_concurrent_append     #473      +/-   ##
=========================================================
+ Coverage                  62.58%   62.65%   +0.07%     
=========================================================
  Files                        133      133              
  Lines                      18358    18372      +14     
=========================================================
+ Hits                       11489    11511      +22     
+ Misses                      6295     6291       -4     
+ Partials                     574      570       -4     
Impacted Files Coverage Δ
pkg/varlog/log.go 0.00% <0.00%> (ø)
pkg/varlog/log_stream_appender.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ijsong
Copy link
Member Author

ijsong commented Jun 16, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

Base automatically changed from lsa_concurrent_append to main June 16, 2023 11:35
@ijsong ijsong merged commit 23236c1 into main Jun 16, 2023
@ijsong ijsong deleted the lsa_close_in_callback branch June 16, 2023 11:35
@ijsong
Copy link
Member Author

ijsong commented Jun 16, 2023

@ijsong merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants