Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add more check rules to Makefile and github action #488

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Jun 20, 2023

No description provided.

@ijsong
Copy link
Member Author

ijsong commented Jun 20, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ijsong ijsong self-assigned this Jun 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11 🎉

Comparison is base (7bf9bf9) 62.04% compared to head (087dd07) 62.16%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@                            Coverage Diff                             @@
##           fix_missing_mock_appendable_logstreams     #488      +/-   ##
==========================================================================
+ Coverage                                   62.04%   62.16%   +0.11%     
==========================================================================
  Files                                         133      133              
  Lines                                       18490    18490              
==========================================================================
+ Hits                                        11473    11495      +22     
+ Misses                                       6436     6417      -19     
+ Partials                                      581      578       -3     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ijsong ijsong marked this pull request as ready for review June 20, 2023 03:32
@ijsong ijsong requested a review from hungryjang as a code owner June 20, 2023 03:32
@ijsong
Copy link
Member Author

ijsong commented Jun 20, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

Base automatically changed from fix_missing_mock_appendable_logstreams to main June 20, 2023 04:24
@ijsong ijsong merged commit 2f17caf into main Jun 20, 2023
@ijsong
Copy link
Member Author

ijsong commented Jun 20, 2023

@ijsong merged this pull request with Graphite.

@ijsong ijsong deleted the fix_ci_check branch June 20, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants