Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(telemetry): add semantic conventions for varlog #505

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Jul 5, 2023

No description provided.

@ijsong ijsong self-assigned this Jul 5, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 32.43% and project coverage change: +0.08 🎉

Comparison is base (36b044b) 62.16% compared to head (195107d) 62.25%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@                            Coverage Diff                             @@
##           mr_dedup_build_commit_results_duration     #505      +/-   ##
==========================================================================
+ Coverage                                   62.16%   62.25%   +0.08%     
==========================================================================
  Files                                         133      133              
  Lines                                       18442    18446       +4     
==========================================================================
+ Hits                                        11465    11484      +19     
+ Misses                                       6405     6394      -11     
+ Partials                                      572      568       -4     
Impacted Files Coverage Δ
internal/storagenode/telemetry/metrics.go 57.14% <28.57%> (+1.31%) ⬆️
internal/storagenode/storagenode.go 73.14% <100.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ijsong ijsong force-pushed the mr_dedup_build_commit_results_duration branch from bca6e0c to 44eead0 Compare July 28, 2023 03:01
@ijsong ijsong force-pushed the otel_varlog_semconv branch from 75030fb to dcff02c Compare July 28, 2023 03:01
@ijsong
Copy link
Member Author

ijsong commented Jul 28, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

Base automatically changed from mr_dedup_build_commit_results_duration to main July 28, 2023 03:49
@ijsong ijsong merged commit 5bb995f into main Jul 28, 2023
@ijsong ijsong deleted the otel_varlog_semconv branch July 28, 2023 03:49
@ijsong
Copy link
Member Author

ijsong commented Jul 28, 2023

@ijsong merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants