chore(benchmark): improve the readability of benchmark stats #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
ijsong
force-pushed
the
benchmark_append_duration_resolution
branch
from
4d03559
to
448603f
Compare
ijsong
force-pushed
the
benchmark_more_readable_stats
branch
from
7622c73
to
8b9823f
Compare
hungryjang
approved these changes
Jul 27, 2023
Before: ``` ___tgt__arpsR__arpsT_______abpsR_______abpsT__adurR__adurT__slpsR__slpsT_______sbpsR_______sbpsT__eelatR__eelatT 1:123664.023244.1 92.44MiB/s 90.8MiB/s 4.0 4.0 0.0 0.0 0B/s 0B/s 0.0 0.0 ``` Current: ``` target_____arps(now,tot)_________abps(now,tot)_adur(now,tot)_____slps(now,tot)_________sbps(now,tot)__eelat(now,tot) 1:1 24.3k/s 23.38k/s 94.93MiB/s 91.32MiB/s 4.4ms 4.6ms 0/s 0/s 0B/s 0B/s 0.0ms 0.0ms ```
ijsong
force-pushed
the
benchmark_append_duration_resolution
branch
from
448603f
to
e3a091d
Compare
ijsong
force-pushed
the
benchmark_more_readable_stats
branch
from
8b9823f
to
7d94665
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## benchmark_append_duration_resolution #523 +/- ##
=====================================================================
Coverage 61.74% 61.75%
=====================================================================
Files 137 137
Lines 18664 18667 +3
=====================================================================
+ Hits 11525 11527 +2
Misses 6565 6565
- Partials 574 575 +1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Before:
Current: