Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): fix typo WithMetricsLogInterval #528

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Jul 14, 2023

What this PR does

Fix typo from WithMetrisLogInterval to WithMetricsLogInterval.

@ijsong ijsong requested a review from hungryjang as a code owner July 14, 2023 00:51
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.17% 🎉

Comparison is base (b34cf10) 61.76% compared to head (2201b10) 61.93%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
+ Coverage   61.76%   61.93%   +0.17%     
==========================================
  Files         137      137              
  Lines       18656    18656              
==========================================
+ Hits        11522    11554      +32     
+ Misses       6558     6537      -21     
+ Partials      576      565      -11     
Files Changed Coverage Δ
internal/storage/config.go 51.33% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong
Copy link
Member Author

ijsong commented Jul 28, 2023

@ijsong started a stack merge that includes this pull request via Graphite.

@ijsong ijsong merged commit 9e724a5 into main Jul 28, 2023
9 checks passed
@ijsong
Copy link
Member Author

ijsong commented Jul 28, 2023

@ijsong merged this pull request with Graphite.

@ijsong ijsong deleted the storage_fix_typo branch July 28, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants