-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security concern with passed credentials #6
Comments
Thank for feedback.
I never thought about proxyfing external AS. Yeah can be an issue. In fact the first goal of putting AS behind Zuul is to take advantage of load balancing and get most resilient AS (we can spawn multiple instances of AS load balanced by Zuul).
I'm not a security expert. In first view I don't see any specific security breach because AS is standalone and manages security by itself. But I can add warning in addition to is currently a POC! |
Thank you! |
First of all, I like your example a lot. It creates nice illusion for browser users that they always interact with one single application. However, doesn't it neglect one of the key benefits (IMO) of the OAuth - avoidance of the credentials sharing? In case when the AS is fully behind proxy and all the login requests are passing the actual credentials though the proxy, won't it be a security concern? Especially when personnel access to AS and proxy is managed in a different way (i.e. proxy is treated less seriously). In case of external AS such as Facebook it becomes even more dangerous.
Am I missing something or this is known limitation? If it is limitation then probably mentioning it in README would help a lot.
Thank you!
The text was updated successfully, but these errors were encountered: