Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

フックの設置 #1

Closed
wants to merge 1 commit into from
Closed

フックの設置 #1

wants to merge 1 commit into from

Conversation

kakkun61
Copy link
Owner

@kakkun61 kakkun61 commented Mar 14, 2024

hs-opentelemetry-instrumentation-hedis herp-inc/hs-opentelemetry#15 を実装するためにフックを新たに設置する

Do not merge

@kakkun61 kakkun61 self-assigned this Mar 14, 2024
src/Database/Redis/PubSub.hs Outdated Show resolved Hide resolved
recv Conn{..} =
receiveHook hooks $ do
(r:rs) <- readIORef connReplies
writeIORef connReplies rs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atomicModifyIORefにしましょう

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

と思ったけれど元からこの実装か……

Copy link

@fumieval fumieval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです

@kakkun61
Copy link
Owner Author

PR した informatikr#223

@kakkun61 kakkun61 closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants