po->opts

[danpovey]

In parts of the code where type OptionsItf is used, for historical reasons the variable name is typically "po" (for ParseOptions). I think this is confusing and should be changed. If someone could find time to do this, that would be helpful. Do it by script if you want.

[naxingyu]

Like "op" for OptionParser, as in Python?

[danpovey]

Previously it was "po" as abbrev for the ParseOptions class. But now an
abstract interface OptionsItf is used, so the variable name "opts" would be
more suitable.
Dan

On Thu, Jul 30, 2015 at 6:53 PM, Xingyu Na notifications@github.com wrote:

Like "op" for OptionParser, as in Python?

—
Reply to this email directly or view it on GitHub
#37 (comment).

[vdp]

In addition to the dumb PR above(I thought "oh, super easy, let's test how PRs work"), I've tried to use the refactoring capabilities of QtCreator, but changing "po->Register(" to "opts->Register(", breaks the indentation for the help message on the next line, and to be honest editing all these files manually, or writing a script doesn't appeal that much to me at the moment...

[danpovey]

I would be OK with a patch that breaks the indentation; we can fix that
gradually as we visit each file.
Dan

On Fri, Jul 31, 2015 at 2:09 AM, Vassil Panayotov notifications@github.com
wrote:

In addition to the dumb PR above(I thought "oh, super easy, let's test how
PRs work"), I've tried to use the refactoring capabilities of QtCreator,
but changing "op->Register(" to "opts->Register(", breaks the indentation
for the help message on the next line, and to be honest editing all these
files manually, or writing a script doesn't appeal that much to me at the
moment...

—
Reply to this email directly or view it on GitHub
#37 (comment).