Delete the obsolete BatchedThreadedNnet3CudaPipeline?

[kkm000]

@hugovbraun, @galv, @danpovey, the module has been declared obsolete 13 months ago in 0bca93e. Is it the time to 👎 it? It has a maintenance burden.

~/work/kaldi/src[master]$ git show 0bca93ea34 cudadecoder/batched-threaded-nnet3-cuda-pipeline.cc
commit 0bca93ea3466b467748105fedbdf16c52383e402
Author: Hugo Braun <hbraun@nvidia.com>
Date:   Thu Apr 30 20:20:34 2020 -0700

    [src] CUDA Online/Offline pipelines + light batched nnet3 driver (#3568)
. . .
--- a/src/cudadecoder/batched-threaded-nnet3-cuda-pipeline.cc
+++ b/src/cudadecoder/batched-threaded-nnet3-cuda-pipeline.cc
@@ -23,12 +23,18 @@
 #include <nvToolsExt.h>
 #include "base/kaldi-utils.h"

+// This pipeline is deprecated and will be removed. Please switch to
+// batched-threaded-nnet3-cuda-pipeline2
+
 namespace kaldi {
 namespace cuda_decoder {

 void BatchedThreadedNnet3CudaPipeline::Initialize(
     const fst::Fst<fst::StdArc> &decode_fst, const nnet3::AmNnetSimple &am_nnet,
     const TransitionModel &trans_model) {
+  KALDI_LOG << "\n\nIMPORTANT: This pipeline is deprecated. Please switch to "
+               "cudadecoderbin/batch-wav-nnet3-cuda2 (binary) or "
+               "cudadecoder/batched-threaded-nnet3-cuda-pipeline2.h (class)\n";
   KALDI_LOG << "BatchedThreadedNnet3CudaPipeline Initialize with "
             << config_.num_control_threads << " control threads, "
             << config_.num_worker_threads << " worker threads"

[danpovey]

Mm, I'd rather keep it a little longer, will reduce the chance of complaints etc.

…

On Fri, May 28, 2021 at 6:36 PM kkm000 ***@***.***> wrote: @hugovbraun <https://github.com/hugovbraun>, @galv <https://github.com/galv>, @danpovey <https://github.com/danpovey>, the module has been declared obsolete 13 months ago in 0bca93e <0bca93e>. Is it the time to 👎 it? It has a maintenance burden. ~/work/kaldi/src[master]$ git show 0bca93e cudadecoder/batched-threaded-nnet3-cuda-pipeline.cc commit 0bca93e Author: Hugo Braun ***@***.***> Date: Thu Apr 30 20:20:34 2020 -0700 [src] CUDA Online/Offline pipelines + light batched nnet3 driver (#3568) . . . --- a/src/cudadecoder/batched-threaded-nnet3-cuda-pipeline.cc +++ b/src/cudadecoder/batched-threaded-nnet3-cuda-pipeline.cc @@ -23,12 +23,18 @@ #include <nvToolsExt.h> #include "base/kaldi-utils.h" +// This pipeline is deprecated and will be removed. Please switch to +// batched-threaded-nnet3-cuda-pipeline2 + namespace kaldi { namespace cuda_decoder { void BatchedThreadedNnet3CudaPipeline::Initialize( const fst::Fst<fst::StdArc> &decode_fst, const nnet3::AmNnetSimple &am_nnet, const TransitionModel &trans_model) { + KALDI_LOG << "\n\nIMPORTANT: This pipeline is deprecated. Please switch to " + "cudadecoderbin/batch-wav-nnet3-cuda2 (binary) or " + "cudadecoder/batched-threaded-nnet3-cuda-pipeline2.h (class)\n"; KALDI_LOG << "BatchedThreadedNnet3CudaPipeline Initialize with " << config_.num_control_threads << " control threads, " << config_.num_worker_threads << " worker threads" — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4546>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZFLO3JUCVKQ3LLWQ5EIULTP5WZXANCNFSM45WJUJZQ> .

[kkm000]

Well, I'm patching it for the second time already (because of CudaFst rework, found the double-free. cuda-memcheck is a pig: it did not detect it). When it would need a third change, I'll kill it. Sounds good?

It's always possible to go back to a pre-delete commit and get it. It won't evaporate completely. As long as the complainers maintain it and not me, I'm totally cool! :)

[danpovey]

Sure...

…

On Fri, May 28, 2021 at 8:14 PM kkm000 ***@***.***> wrote: Well, I'm patching it for the second time already (because of CudaFst rework, found the double-free. cuda-memcheck is a pig: it did not detect it). When it would need a third change, I'll kill it. Sounds good? It's always possible to go back to a pre-delete commit and get it. It won't evaporate completely. As long as the complainers maintain it and not me, I'm totally cool! :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4546 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZFLO6AZ5R2IXHE5XUE3ODTP6CJFANCNFSM45WJUJZQ> .

[kkm000]

Closing this to reduce clutter.