Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to wav-reverberate command #716

Closed
vijayaditya opened this issue Apr 19, 2016 · 2 comments
Closed

Enhancements to wav-reverberate command #716

vijayaditya opened this issue Apr 19, 2016 · 2 comments
Labels
help wanted Please help us with this issue!

Comments

@vijayaditya
Copy link
Contributor

We are updating the wav-reverberate command to support a new data reverberation script (See PR #706 ). For this script we need to update the C++ binary to have the following command line format. (This issue is based on requirements in #552)


wav-reverberate --inpulse-response=<rir-wav> \
--additive-signals='<isotropic-noise-wav>, "wav-reverberate --duration <t> --impulse-response=<point-source1-rir-wav> <point-source1-noise-wav> - |", "wav-reverberate --duration  <t2> --impulse-response=<point-source2-rir-wav> <point-source2-noise-wav> - |"' \
  --snrs=' <isotropic-snr-db> ,<point-source1-snr-db>,<point-source2-snr-db>' \
  --start-times='< s0,s1,s2 >' '  <input>  <output>

@vijayaditya vijayaditya added the help wanted Please help us with this issue! label Apr 19, 2016
@danpovey
Copy link
Contributor

I think the following is better / easier to deal with internally:

--additive-signals=',wav-reverberate --duration
--impulse-response=
- |,wav-reverberate --duration
--impulse-response= -
|'

On Tue, Apr 19, 2016 at 1:51 PM, Vijayaditya Peddinti <
notifications@github.com> wrote:

We are updating the wav-reverberate command to support a new data
reverberation script (See PR #706
#706 ). For this script we need
to update the C++ binary to have the following command line format. (This
issue is based on requirements in #552
#552)

wav-reverberate --inpulse-response=
--additive-signals=', "wav-reverberate --duration --impulse-response= - |", "wav-reverberate --duration --impulse-response= - |"'
--snrs=' ,,'
--start-times='< s0,s1,s2 >' '


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#716

@vijayaditya
Copy link
Contributor Author

FYI @tomkocse has picked this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Please help us with this issue!
Projects
None yet
Development

No branches or pull requests

2 participants