Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around an apparent namespace-in-template scoping bug in MSVC on Windows #4

Closed
wants to merge 1 commit into from
Closed

Work around an apparent namespace-in-template scoping bug in MSVC on Windows #4

wants to merge 1 commit into from

Conversation

kkm000
Copy link
Contributor

@kkm000 kkm000 commented May 19, 2015

Work around an apparent namespace-in-template scoping bug in MSVC on Windows

@kkm000 kkm000 closed this May 19, 2015
@danpovey
Copy link
Contributor

Kirill,
I am not comfortable with the way you are proposing to work around this MSVC bug by moving main() into namespace kaldi. It seems like you are just introducing a different bug into Kaldi
Per this conversation
http://stackoverflow.com/questions/3956678/main-in-namespace
it looks to me like the C++ standard does not allow main to be in a namespace.
Even if this compiles (and I doubt it will on all compilers), to me it doesn't pass the smell test. Is there another possible fix?
Dan

danpovey referenced this pull request Aug 19, 2015
@danpovey
Merge pull request #47 from naxingyu/convolution-nnet2
5526c21 
add Convolution component in nnet2
@danpovey danpovey mentioned this pull request Mar 2, 2016
Closed
vimalmanohar referenced this pull request in vimalmanohar/kaldi Nov 4, 2016
@david-ryan-snyder
Merge pull request #4 from mmaciej2/kaldi-diarization
8e6c19d 
Created data preparation script
@danpovey danpovey mentioned this pull request Dec 2, 2016
Merged
@danpovey danpovey mentioned this pull request Feb 7, 2017
Merged
keli78 pushed a commit to keli78/kaldi that referenced this pull request Feb 8, 2017
@hainan-xv
Merge pull request kaldi-asr#4 from freewym/shortcut2
ae9b986 
cuda kernels for sparse matrix affine forward/backward prop
@danpovey danpovey mentioned this pull request Mar 7, 2017
Closed
@chandlerz chandlerz mentioned this pull request Sep 6, 2017
Closed
Szu-JuiChen referenced this pull request in Szu-JuiChen/kaldi Feb 22, 2018
@Szu-JuiChen
Merge pull request #4 from Szu-JuiChen/lmrescore
f873c36 
[egs] Add options
LvHang referenced this pull request in LvHang/kaldi Aug 10, 2018
@chenzhehuai
Merge pull request #4 from kaldi-asr/master
c7eb4c5 
from master
@danpovey danpovey mentioned this pull request Sep 18, 2018
Closed
underdogliu pushed a commit to underdogliu/kaldi that referenced this pull request Mar 6, 2019
@alex-ht
alex-patch-2 (kaldi-asr#4)
5740120 
* remove redundant code

* simplify local/prepare_data.sh

* syntax error

* 1. add local/run_cleanup_segmentation.sh 2. some minor fix
results:
```bash
$ ./run.sh --stage 10
./run.sh: extract the results
WER: test
%WER 61.18 [ 83187 / 135972, 5435 ins, 19162 del, 58590 sub ] exp/mono/decode_test/wer_11_0.0
%WER 40.83 [ 55522 / 135972, 5837 ins, 14160 del, 35525 sub ] exp/tri1/decode_test/wer_14_0.5
%WER 40.47 [ 55028 / 135972, 7068 ins, 12165 del, 35795 sub ] exp/tri2/decode_test/wer_15_0.0
%WER 38.68 [ 52597 / 135972, 7443 ins, 10447 del, 34707 sub ] exp/tri3a/decode_test/wer_14_0.0
%WER 35.83 [ 48720 / 135972, 7536 ins, 9490 del, 31694 sub ] exp/tri4a/decode_test/wer_17_0.0
%WER 39.92 [ 54286 / 135972, 7407 ins, 10832 del, 36047 sub ] exp/tri4a/decode_test.si/wer_15_0.0
%WER 32.17 [ 43748 / 135972, 7387 ins, 8396 del, 27965 sub ] exp/tri5a_cleaned/decode_test/wer_17_0.0
%WER 35.93 [ 48853 / 135972, 6489 ins, 10720 del, 31644 sub ] exp/tri5a_cleaned/decode_test.si/wer_14_0.5
%WER 32.30 [ 43923 / 135972, 6105 ins, 10183 del, 27635 sub ] exp/tri5a/decode_test/wer_17_0.5
%WER 36.10 [ 49092 / 135972, 6258 ins, 11197 del, 31637 sub ] exp/tri5a/decode_test.si/wer_14_0.5
%WER 23.95 [ 32568 / 135972, 4457 ins, 10271 del, 17840 sub ] exp/chain/tdnn_1a_sp/decode_test/wer_10_0.0
%WER 24.67 [ 33546 / 135972, 5358 ins, 7920 del, 20268 sub ] exp/nnet3/tdnn_sp/decode_test/wer_13_0.0

CER: test
%WER 54.20 [ 116924 / 215718, 4789 ins, 24777 del, 87358 sub ] exp/mono/decode_test/cer_10_0.0
%WER 32.36 [ 69805 / 215718, 6105 ins, 16033 del, 47667 sub ] exp/tri1/decode_test/cer_13_0.0
%WER 32.11 [ 69260 / 215718, 6289 ins, 15492 del, 47479 sub ] exp/tri2/decode_test/cer_13_0.0
%WER 30.44 [ 65661 / 215718, 6338 ins, 14062 del, 45261 sub ] exp/tri3a/decode_test/cer_13_0.0
%WER 27.55 [ 59439 / 215718, 6267 ins, 13074 del, 40098 sub ] exp/tri4a/decode_test/cer_16_0.0
%WER 31.56 [ 68074 / 215718, 6283 ins, 14101 del, 47690 sub ] exp/tri4a/decode_test.si/cer_13_0.0
%WER 24.16 [ 52121 / 215718, 6690 ins, 10620 del, 34811 sub ] exp/tri5a_cleaned/decode_test/cer_14_0.0
%WER 27.84 [ 60050 / 215718, 6778 ins, 11600 del, 41672 sub ] exp/tri5a_cleaned/decode_test.si/cer_12_0.0
%WER 24.43 [ 52710 / 215718, 6722 ins, 11040 del, 34948 sub ] exp/tri5a/decode_test/cer_14_0.0
%WER 28.04 [ 60494 / 215718, 6760 ins, 11980 del, 41754 sub ] exp/tri5a/decode_test.si/cer_12_0.0
%WER 16.83 [ 36305 / 215718, 4772 ins, 10810 del, 20723 sub ] exp/chain/tdnn_1a_sp/decode_test/cer_9_0.0
%WER 17.24 [ 37188 / 215718, 4880 ins, 9721 del, 22587 sub ] exp/nnet3/tdnn_sp/decode_test/cer_12_0.0

./run.sh: all done
```
@luitjens luitjens mentioned this pull request Jul 1, 2019
Closed
@danpovey danpovey mentioned this pull request Sep 18, 2019
Closed
megazone87 pushed a commit to megazone87/kaldi that referenced this pull request Nov 22, 2019
Merge pull request kaldi-asr#4 from kaldi-asr/master
c1e62d9 
merge from kaldi-asr/master
@mohan-li mohan-li mentioned this pull request Jan 10, 2020
Closed
@danpovey danpovey mentioned this pull request Feb 20, 2020
Closed
@jtrmal jtrmal mentioned this pull request Jun 4, 2020
Merged
@danpovey danpovey mentioned this pull request Jun 12, 2020
Closed
@522730312 522730312 mentioned this pull request Jun 13, 2020
Open
desh2608 added a commit to desh2608/kaldi that referenced this pull request Sep 11, 2020
@desh2608
Merge pull request kaldi-asr#4 from jsalt2020-asrdiar/libricss
831c107 
RNNLM rescoring and multichannel recipe
syfengcuhk referenced this pull request in syfengcuhk/kaldi Sep 25, 2020
@syfengcuhk
Merge pull request #4 from syfengcuhk/discophone
523bbe9 
Discophone
@danpovey danpovey mentioned this pull request Jan 13, 2021
Closed
@Veango Veango mentioned this pull request Sep 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkm000 @danpovey @jtrmal