Fix compilation issues when using KALDI_DOUBLEPRECISION=1 #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3933,7 +3933,7 @@ void Convolutional1dComponent::Propagate(const ChunkInfo &in_info, | |||
| } | |||
|
|
|||
| // apply all filters | |||
| AddMatMatBatched(1.0f, tgt_batch, patch_batch, kNoTrans, filter_params_batch, | |||
| AddMatMatBatched<BaseFloat>(1.0f, tgt_batch, patch_batch, kNoTrans, filter_params_batch, | |||
There was a problem hiding this comment.
Since we're at it, could you please replace the 1.0f in these AddMatMatBatched calls with 1.0?
1.0f seems to have been an attempt to call the version of the template, but isn't needed and is confusing.
|
Ok, I'll do it. |
|
Thanks! Merging. |
danpovey
added a commit
that referenced
this pull request
Jan 28, 2016
Fix compilation issues when using KALDI_DOUBLEPRECISION=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some compilation issues by specifying templates instead of letting the compiler guess and replacing hardcoded floats in signal processing by BaseFloat typedef
When dealing with rnnlm, floats are used everywhere, no matter what the precision of the rest of Kaldi is (it was already like that in most of the rnnlm code, with a few exceptions)