Documentation changes related to Git migration #50

kkm000 · 2015-08-04T03:37:05Z

Added Git tutorial, removed Subversion tutorial and updated multiple references from Subversion to Git and from SourceForge to Kaldi's own web site or GitHub as appropriate.

Please comment on particular issues in-line on GitHub page as the change list is large.

EDIT: Many whitespace changes here because of my emacs setup. Add ?w=0 to the end of the URL to show only non-whitespace changes, e. g.

https://github.com/kaldi-asr/kaldi/pull/50/files?w=0

…l and updated multiple references from Subversion to Git and from SourceForge to Kaldi's own web site or GitHub as appropriate.

danpovey · 2015-08-04T04:06:20Z

Thanks.. couple of points;
regarding dependencies, we still depend on svn being installed to install
some other stuff.

Regarding this, "
We still intend to maintain a+ read-only Subversion mirror of the GitHub
parent, located at SourceForge and mirrored+ by us."
this is no longer the plan, because Sourceforge lost our latest svn commits
and if we attempt to keep the SF up to date, existing SF users would likely
get corrupted copies of Kaldi.
There is a todo in your commit:
+\todo This paragraph is full of lies!
it would be good if you can find time to fix this before we merge the pull
request.
Dan

On Mon, Aug 3, 2015 at 8:37 PM, Kirill Katsnelson notifications@github.com
wrote:

Added Git tutorial, removed Subversion tutorial and updated multiple
references from Subversion to Git and from SourceForge to Kaldi's own web
site or GitHub as appropriate.

Please comment on particular issues in-line on GitHub page as the change

list is large.

You can view, comment on, or merge this pull request online at:

#50
Commit Summary

Documentation changes: added Git tutorial, removed Subversion
tutorial and updated multiple references from Subversion to Git and from
SourceForge to Kaldi's own web site or GitHub as appropriate.

File Changes

M src/doc/about.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-0 (45)

M src/doc/dependencies.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-1 (14)

M src/doc/install.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-2 (52)

M src/doc/legal.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-3 (30)

M src/doc/other.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-4 (17)

M src/doc/tutorial.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-5 (2)

M src/doc/tutorial_code.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-6 (37)

A src/doc/tutorial_git.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-7 (259)

M src/doc/tutorial_looking.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-8 (30)

M src/doc/tutorial_prereqs.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-9 (6)

M src/doc/tutorial_setup.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-10 (18)

D src/doc/tutorial_svn.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-11 (70)

Patch Links:

https://github.com/kaldi-asr/kaldi/pull/50.patch

https://github.com/kaldi-asr/kaldi/pull/50.diff

—
Reply to this email directly or view it on GitHub
#50.

…r is not maintained; version control paragraph in tutorial_code.dox rewritten.

jtrmal · 2015-08-04T14:06:27Z

BTW, one more comment (of low importance, probably shouldn't be an an
obstacle in merging this PR): I think we can say nicer things about the
windows built now.
I wouldn't claim it's actively supported but the sentence there (woefully
old, or something like that) is too grim :)
y.

On Tue, Aug 4, 2015 at 12:06 AM, Daniel Povey notifications@github.com
wrote:

Thanks.. couple of points;
regarding dependencies, we still depend on svn being installed to install
some other stuff.

Regarding this, "
We still intend to maintain a+ read-only Subversion mirror of the GitHub
parent, located at SourceForge and mirrored+ by us."
this is no longer the plan, because Sourceforge lost our latest svn commits
and if we attempt to keep the SF up to date, existing SF users would likely
get corrupted copies of Kaldi.
There is a todo in your commit:
+\todo This paragraph is full of lies!
it would be good if you can find time to fix this before we merge the pull
request.
Dan

On Mon, Aug 3, 2015 at 8:37 PM, Kirill Katsnelson <
notifications@github.com>
wrote:

Added Git tutorial, removed Subversion tutorial and updated multiple
references from Subversion to Git and from SourceForge to Kaldi's own web
site or GitHub as appropriate.

Please comment on particular issues in-line on GitHub page as the change

list is large.

You can view, comment on, or merge this pull request online at:

#50
Commit Summary

Documentation changes: added Git tutorial, removed Subversion
tutorial and updated multiple references from Subversion to Git and from
SourceForge to Kaldi's own web site or GitHub as appropriate.

File Changes

M src/doc/about.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-0 (45)

M src/doc/dependencies.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-1 (14)

M src/doc/install.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-2 (52)

M src/doc/legal.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-3 (30)

M src/doc/other.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-4 (17)

M src/doc/tutorial.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-5 (2)

M src/doc/tutorial_code.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-6 (37)

A src/doc/tutorial_git.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-7 (259)

M src/doc/tutorial_looking.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-8 (30)

M src/doc/tutorial_prereqs.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-9 (6)

M src/doc/tutorial_setup.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-10 (18)

D src/doc/tutorial_svn.dox
https://github.com/kaldi-asr/kaldi/pull/50/files#diff-11 (70)

Patch Links:

https://github.com/kaldi-asr/kaldi/pull/50.patch

https://github.com/kaldi-asr/kaldi/pull/50.diff

—
Reply to this email directly or view it on GitHub
#50.

—
Reply to this email directly or view it on GitHub
#50 (comment).

kkm000 · 2015-08-04T15:32:53Z

@jtrmal:

probably shouldn't be an an obstacle in merging this PR

I think it should :-) As a sidekick thought, a PR might well represent a completed unit of work, since it is merged into the master branch as a functional feature. It makes perfect sense to discuss the changes and iteratively modify the change until it is logically complete. Git much better suited for this than svn, as it is much easier with it to have multiple branches and multiple PRs going at a time. So...

we can say nicer things about the windows built now.

...I'll change this later today, do not merge.

kkm000 · 2015-08-04T18:57:56Z

@danpovey, @jtrmal, out of curiosity, are you getting a notification from GitHub when I push a commit to the existing PR? In the tutorial, I assumed not.

jtrmal · 2015-08-04T18:59:11Z

No, I didn't get informed about the last commit.
y.

On Tue, Aug 4, 2015 at 2:57 PM, Kirill Katsnelson notifications@github.com
wrote:

@danpovey https://github.com/danpovey, @jtrmal
https://github.com/jtrmal, out of curiosity, are you getting a
notification from GitHub when I push a commit to the existing PR? In the
tutorial, I assumed not.

—
Reply to this email directly or view it on GitHub
#50 (comment).

kkm000 · 2015-08-04T19:06:03Z

Aha, and Dan was, although that was an out-of-thread e-mail message with a new subject! NB the commit message did literally contain @danpovey, and this one did not mention you. Interesting. Looks like GitHub would not notify the owner of the target repo of a push to the existing PR.

I have a line mentioning to respond with something like "Done" in the thread--looks like it makes total sense. Thanks for checking!

jtrmal · 2015-08-04T19:26:49Z

OK, I guess it's ready to merge?

danpovey · 2015-08-04T19:28:33Z

I guess.
Won't hurt to merge it in any case. After you merge, I'll compile.
Dan

On Tue, Aug 4, 2015 at 12:26 PM, jtrmal notifications@github.com wrote:

OK, I guess it's ready to merge?

—
Reply to this email directly or view it on GitHub
#50 (comment).

Documentation changes related to Git migration

danpovey · 2015-08-04T19:32:30Z

Thanks. Compiling now. Yenda, in a few minutes the docs will appear
online, could you please make sure there are no gross formatting errors?
Dan

On Tue, Aug 4, 2015 at 12:29 PM, jtrmal notifications@github.com wrote:

Merged #50 #50.

—
Reply to this email directly or view it on GitHub
#50 (comment).

jtrmal · 2015-08-04T19:33:40Z

yep, will do. y.

On Tue, Aug 4, 2015 at 3:32 PM, Daniel Povey notifications@github.com
wrote:

Thanks. Compiling now. Yenda, in a few minutes the docs will appear
online, could you please make sure there are no gross formatting errors?
Dan

On Tue, Aug 4, 2015 at 12:29 PM, jtrmal notifications@github.com wrote:

Merged #50 #50.

—
Reply to this email directly or view it on GitHub
#50 (comment).

—
Reply to this email directly or view it on GitHub
#50 (comment).

jtrmal · 2015-08-04T20:49:23Z

everything seems fine.
y.

On Tue, Aug 4, 2015 at 3:33 PM, Jan Trmal jtrmal@gmail.com wrote:

yep, will do. y.

On Tue, Aug 4, 2015 at 3:32 PM, Daniel Povey notifications@github.com
wrote:

Thanks. Compiling now. Yenda, in a few minutes the docs will appear
online, could you please make sure there are no gross formatting errors?
Dan

On Tue, Aug 4, 2015 at 12:29 PM, jtrmal notifications@github.com wrote:

Merged #50 #50.

—
Reply to this email directly or view it on GitHub
#50 (comment).

—
Reply to this email directly or view it on GitHub
#50 (comment).

kkm000 · 2015-08-04T22:50:37Z

@jtrmal Thanks for checking.

added WER scoring

Documentation changes: added Git tutorial, removed Subversion tutoria…

08024e9

…l and updated multiple references from Subversion to Git and from SourceForge to Kaldi's own web site or GitHub as appropriate.

Addressing @danpovey comments: svn is still a prerequisite; svn mirro…

fbe35a9

…r is not maintained; version control paragraph in tutorial_code.dox rewritten.

Windows build is slightly more maintained than not. :-)

3f3dc6b

jtrmal added a commit that referenced this pull request Aug 4, 2015

Merge pull request #50 from kkm000/gittutorial

ec358b9

Documentation changes related to Git migration

jtrmal merged commit ec358b9 into kaldi-asr:master Aug 4, 2015

kkm000 deleted the gittutorial branch August 4, 2015 22:50

hainan-xv pushed a commit to hainan-xv/kaldi that referenced this pull request Jul 24, 2018

Merge pull request kaldi-asr#50 from sw005320/swbd

6e5afc4

added WER scoring

mohan-li mentioned this pull request Jan 10, 2020

Segmentation fault when importing kaldi_pybind #3836

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Documentation changes related to Git migration #50

Documentation changes related to Git migration #50

kkm000 commented Aug 4, 2015

danpovey commented Aug 4, 2015

list is large.

jtrmal commented Aug 4, 2015

list is large.

kkm000 commented Aug 4, 2015

kkm000 commented Aug 4, 2015

jtrmal commented Aug 4, 2015

kkm000 commented Aug 4, 2015

jtrmal commented Aug 4, 2015

danpovey commented Aug 4, 2015

danpovey commented Aug 4, 2015

jtrmal commented Aug 4, 2015

jtrmal commented Aug 4, 2015

kkm000 commented Aug 4, 2015

Documentation changes related to Git migration #50

Documentation changes related to Git migration #50

Conversation

kkm000 commented Aug 4, 2015

danpovey commented Aug 4, 2015

list is large.

jtrmal commented Aug 4, 2015

list is large.

kkm000 commented Aug 4, 2015

kkm000 commented Aug 4, 2015

jtrmal commented Aug 4, 2015

kkm000 commented Aug 4, 2015

jtrmal commented Aug 4, 2015

danpovey commented Aug 4, 2015

danpovey commented Aug 4, 2015

jtrmal commented Aug 4, 2015

jtrmal commented Aug 4, 2015

kkm000 commented Aug 4, 2015