feat: extends frozen of LocalInformation for Object.seal and `Objec…

…t.preventExtensions`
kaleidawave · Oct 30, 2024 · dd8be57 · dd8be57
1 parent 1f5bafa
commit dd8be57
Show file tree

Hide file tree

Showing 5 changed files with 55 additions and 10 deletions.
diff --git a/checker/src/context/information.rs b/checker/src/context/information.rs
@@ -1,5 +1,5 @@
 use source_map::SpanWithSource;
-use std::collections::{HashMap, HashSet};
+use std::collections::HashMap;
 
 use crate::{
 	events::{Event, RootReference},
@@ -32,8 +32,8 @@ pub struct LocalInformation {
 	/// `ContextId` is a mini context
 	pub(crate) closure_current_values: HashMap<(ClosureId, RootReference), TypeId>,
 
-	/// Not writeable, `TypeError: Cannot add property t, object is not extensible`. TODO conditional ?
-	pub(crate) frozen: HashSet<TypeId>,
+	/// Not writeable, `TypeError: Cannot add property, object is not extensible`. TODO conditional ?
+	pub(crate) frozen: HashMap<TypeId, ObjectProtectionState>,
 
 	/// Object type (LHS), must always be RHS
 	///
@@ -52,6 +52,13 @@ pub struct LocalInformation {
 	pub(crate) value_of_this: ThisValue,
 }
 
+#[derive(Debug, Clone, Copy, binary_serialize_derive::BinarySerializable)]
+pub enum ObjectProtectionState {
+	Frozen,
+	Sealed,
+	NoExtensions,
+}
+
 #[derive(Debug, Default, binary_serialize_derive::BinarySerializable, Clone)]
 pub(crate) enum ReturnState {
 	#[default]
@@ -228,7 +235,7 @@ impl LocalInformation {
 			.extend(other.current_properties.iter().map(|(l, r)| (*l, r.clone())));
 		self.closure_current_values
 			.extend(other.closure_current_values.iter().map(|(l, r)| (l.clone(), *r)));
-		self.frozen.extend(other.frozen.iter().clone());
+		self.frozen.extend(other.frozen.clone());
 		self.narrowed_values.extend(other.narrowed_values.iter().copied());
 		self.state = other.state.clone();
 	}

diff --git a/checker/src/context/mod.rs b/checker/src/context/mod.rs
@@ -7,6 +7,7 @@ pub mod information;
 pub mod invocation;
 mod root;
 
+use information::ObjectProtectionState;
 pub(crate) use invocation::CallCheckingBehavior;
 pub use root::RootContext;
 
@@ -518,7 +519,7 @@ impl<T: ContextType> Context<T> {
 	}
 
 	/// TODO doesn't look at aliases using `get_type_fact`!
-	pub fn is_frozen(&self, value: TypeId) -> Option<TypeId> {
+	pub fn is_frozen(&self, value: TypeId) -> Option<ObjectProtectionState> {
 		self.parents_iter().find_map(|ctx| get_on_ctx!(ctx.info.frozen.get(&value))).copied()
 	}
 

diff --git a/checker/src/features/constant_functions.rs b/checker/src/features/constant_functions.rs
@@ -2,7 +2,11 @@ use iterator_endiate::EndiateIteratorExt;
 use source_map::SpanWithSource;
 
 use crate::{
-	context::{get_on_ctx, information::InformationChain, invocation::CheckThings},
+	context::{
+		get_on_ctx,
+		information::{InformationChain, ObjectProtectionState},
+		invocation::CheckThings,
+	},
 	events::printing::debug_effects,
 	features::objects::{ObjectBuilder, Proxy},
 	types::{
@@ -310,7 +314,27 @@ pub(crate) fn call_constant_function(
 			if let Some(on) =
 				(arguments.len() == 1).then(|| arguments[0].non_spread_type().ok()).flatten()
 			{
-				environment.info.frozen.insert(on);
+				environment.info.frozen.insert(on, ObjectProtectionState::Frozen);
+				Ok(ConstantOutput::Value(on))
+			} else {
+				Err(ConstantFunctionError::CannotComputeConstant)
+			}
+		}
+		"seal" => {
+			if let Some(on) =
+				(arguments.len() == 1).then(|| arguments[0].non_spread_type().ok()).flatten()
+			{
+				environment.info.frozen.insert(on, ObjectProtectionState::Sealed);
+				Ok(ConstantOutput::Value(on))
+			} else {
+				Err(ConstantFunctionError::CannotComputeConstant)
+			}
+		}
+		"preventExtensions" => {
+			if let Some(on) =
+				(arguments.len() == 1).then(|| arguments[0].non_spread_type().ok()).flatten()
+			{
+				environment.info.frozen.insert(on, ObjectProtectionState::NoExtensions);
 				Ok(ConstantOutput::Value(on))
 			} else {
 				Err(ConstantFunctionError::CannotComputeConstant)
@@ -321,12 +345,23 @@ pub(crate) fn call_constant_function(
 				(arguments.len() == 1).then(|| arguments[0].non_spread_type().ok()).flatten()
 			{
 				let is_frozen =
-					environment.get_chain_of_info().any(|info| info.frozen.contains(&on));
+					environment.get_chain_of_info().any(|info| info.frozen.contains_key(&on));
 				Ok(ConstantOutput::Value(if is_frozen { TypeId::TRUE } else { TypeId::FALSE }))
 			} else {
 				Err(ConstantFunctionError::CannotComputeConstant)
 			}
 		}
+		"isSealed" => {
+			if let Some(on) =
+				(arguments.len() == 1).then(|| arguments[0].non_spread_type().ok()).flatten()
+			{
+				let is_sealed =
+					environment.get_chain_of_info().any(|info| info.frozen.contains_key(&on));
+				Ok(ConstantOutput::Value(if is_sealed { TypeId::TRUE } else { TypeId::FALSE }))
+			} else {
+				Err(ConstantFunctionError::CannotComputeConstant)
+			}
+		}
 		"defineProperty" => {
 			// TODO check configurable
 			if let [on, property, descriptor] = arguments {

diff --git a/checker/src/types/properties/assignment.rs b/checker/src/types/properties/assignment.rs
@@ -60,7 +60,7 @@ pub fn set_property<B: CallCheckingBehavior>(
 ) -> SetPropertyResult {
 	// Frozen checks
 	{
-		if environment.info.frozen.contains(&on) {
+		if environment.info.frozen.contains_key(&on) {
 			return Err(SetPropertyError::NotWriteable {
 				property: PropertyKeyRepresentation::new(under, environment, types),
 				position,

diff --git a/checker/src/types/subtyping.rs b/checker/src/types/subtyping.rs
@@ -764,7 +764,9 @@ pub(crate) fn type_is_subtype_with_generics(
 							information,
 							types,
 						)
-					} else if information.get_chain_of_info().any(|info| info.frozen.contains(&ty))
+					} else if information
+						.get_chain_of_info()
+						.any(|info| info.frozen.contains_key(&ty))
 						|| matches!(subtype, Type::Constant(_))
 						|| matches!(
 							ty,