Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various stylelint updates #255

Merged
merged 5 commits into from
Dec 27, 2023
Merged

Various stylelint updates #255

merged 5 commits into from
Dec 27, 2023

Conversation

EECOLOR
Copy link
Member

@EECOLOR EECOLOR commented Oct 27, 2023

No description provided.

@EECOLOR EECOLOR requested a review from ErwinCode October 27, 2023 13:45
@EECOLOR EECOLOR changed the title Add dvh and dvw as intrinsic units Various stylelint updates Oct 28, 2023
@EECOLOR
Copy link
Member Author

EECOLOR commented Oct 28, 2023

Note to self: Dit patroon veroorzaakt problemen:

.abc {
  position: 'relative';

  &.def { 
    position: 'static';
  }

  & > .ghi {
    position: 'absolute';
  }
}

position: 'static' mag niet wanneer 1 van de kinderen op 'absolute' is gezet.

@ErwinCode
Copy link

Note to self: Dit patroon veroorzaakt problemen:

.abc {
  position: 'relative';

  &.def { 
    position: 'static';
  }

  & > .ghi {
    position: 'absolute';
  }
}

position: 'static' mag niet wanneer 1 van de kinderen op 'absolute' is gezet.

@EECOLOR Hier de rules die daarbij horen: https://github.com/kaliberjs/build/tree/master/library/stylelint-plugins/rules/parent-child-policy#position-absolute

@@ -210,7 +210,13 @@
"vmax",
"deg",
"turn",
"fr"
"fr",
"dvh",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@EECOLOR
Copy link
Member Author

EECOLOR commented Oct 31, 2023

Note to self: Dit patroon veroorzaakt problemen:

.abc {
  position: 'relative';

  &.def { 
    position: 'static';
  }

  & > .ghi {
    position: 'absolute';
  }
}

position: 'static' mag niet wanneer 1 van de kinderen op 'absolute' is gezet.

@EECOLOR Hier de rules die daarbij horen: https://github.com/kaliberjs/build/tree/master/library/stylelint-plugins/rules/parent-child-policy#position-absolute

@ErwinCode Klopt. Het probleem waar ik op doelde is dat in het voorbeeld .abc met .def erbij .ghi laat ontsnappen. De linter zou eigenlijk moeten zeggen dat position: static in .def niet mag omdat .ghi een position: absolute heeft.

@EECOLOR
Copy link
Member Author

EECOLOR commented Dec 8, 2023

Ander ding: text-align zou eigenlijk alleen mogen op 'leaf' components

@EECOLOR
Copy link
Member Author

EECOLOR commented Dec 14, 2023

inline-grid als parent van grid properties

@EECOLOR
Copy link
Member Author

EECOLOR commented Dec 14, 2023

text-align: center alleen op 'leaf' components

@EECOLOR
Copy link
Member Author

EECOLOR commented Dec 22, 2023

regels voor has

@EECOLOR EECOLOR marked this pull request as draft December 22, 2023 09:50
@EECOLOR
Copy link
Member Author

EECOLOR commented Dec 22, 2023

Note to self: dingen die makkelijk doorgevoerd kunnen worden doorvoeren (met tests). Voor de rest een ander ticket maken.

@EECOLOR
Copy link
Member Author

EECOLOR commented Dec 27, 2023

#258

@EECOLOR EECOLOR marked this pull request as ready for review December 27, 2023 15:06
@EECOLOR EECOLOR merged commit 1725c2b into master Dec 27, 2023
2 checks passed
@EECOLOR EECOLOR deleted the stylelint-updates branch December 27, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants