Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit translations? #345

Closed
nagyrobi opened this issue Jun 29, 2020 · 4 comments · Fixed by #363 or #380
Closed

Submit translations? #345

nagyrobi opened this issue Jun 29, 2020 · 4 comments · Fixed by #363 or #380
Labels
enhancement New feature or request

Comments

@nagyrobi
Copy link
Contributor

I'd like to translate the buttons "LEAVE" "UNGOUP" "GROUP ALL" etc. to my language. According to the changelog it supports translation but I see these in English only. Where can I contribute with the strings for my language?

@kalkih kalkih added the enhancement New feature or request label Jun 29, 2020
@kalkih
Copy link
Owner

kalkih commented Jun 29, 2020

Hello,

I'm currently piggybacking on the translations in the Home Assistant frontend, see translations/frontend.
Unfortunately there aren't appropriate ones available for all text elements of the card, that's why some elements aren't translated.

We could potentially add some sort of built-in translation support in the future, where users can provide translations directly in this project. I'll treat this as a feature request.

Thanks!

@nagyrobi
Copy link
Contributor Author

Cool.
A good approach would be maybe to have a resource file containing a dictionaries with strings for the UI elements to be translated. If resource file not present - operate like now.
If current language not found in the resource file - operate like now.
If certain strings are present in the resource take them from there, if not - operate like now.
This way one could add strings specific to this, missing from Home Assistant frontend, or could even override the ones that exist but don't like.

@kalkih kalkih linked a pull request Jul 29, 2020 that will close this issue
@kalkih kalkih changed the title Translation? Submit translations? Jul 29, 2020
@kalkih
Copy link
Owner

kalkih commented Aug 3, 2020

You can now submit translations for your language in the translations file

@kalkih kalkih closed this as completed Aug 3, 2020
@nagyrobi
Copy link
Contributor Author

nagyrobi commented Aug 5, 2020

Can you please add a label for "(master)" string too?

@kalkih kalkih linked a pull request Aug 5, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants