Update fallback border-radius to latest HA style #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, As for backwards compatibility; I think if it's possible and not a huge hassle / much additional complexity it's great to at least aim to support the last few versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default border-radius of
ha-cardis now 12px, which is causing the player contents to flow outside the card. Since the container needsoverflow: visibleto allow things like the source dropdown to expand beyond the player itself, it seems most appropriate to have the player contents respect the default. Perhaps this is a regression for older HA installs? Not sure what your stance is regarding maintaining backwards compatibility - worst case scenario I think is older installs could use the css variableha-card-border-radiusto override for their needs. However, I think going forward we should try to keep up-to-date with what the HA frontend is doing.