Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace modernizr.js by CSS any-hover:hover media feature #527

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

tenzap
Copy link
Collaborator

@tenzap tenzap commented Dec 12, 2024

When trying to update to modernizr v3.13.0, it appeared that:

  • we would have had to rename all "hidden" classes to another name because it conflicts with the hidden class set by Modernizr v3 in its standard config
  • the "touch" class was replaced by either thouchevents or pointerevents making it less reliable for our use case
  • it is possible to detect whether the device supports hover in CSS through any-hover:hover media feature. So we make use of this. See: Implications of a hover detect in Modernizr Modernizr/Modernizr#873 (comment)

When trying to update to modernizr v3.13.0, it appeared that:
- we would have had to rename all "hidden" classes to another name because it
conflicts with the hidden class set by Modernizr v3 in its standard config
- the "touch" class was replaced by either thouchevents or pointerevents
making it less reliable for our use case
- it is possible to detect whether the device supports hover in CSS through
any-hover:hover media feature. So we make use of this.
See: Modernizr/Modernizr#873 (comment)
@tenzap
Copy link
Collaborator Author

tenzap commented Dec 12, 2024

thanks, can you approve #526 & #523 as well ?

@tenzap tenzap merged commit c466346 into kalkun-sms:devel Dec 12, 2024
14 checks passed
@tenzap tenzap deleted the feature-209-dropModernizr branch December 12, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants